-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[AIRFLOW-6140] Add missing types for some core classes. #6702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6140] Add missing types for some core classes. #6702
Conversation
|
That's the first of the following PRs after executors unentangling - adds some missing types and cleans up some of the core classes. |
eeb2d5c to
bf86973
Compare
cd7972a to
70b1b3e
Compare
70b1b3e to
f2c1e66
Compare
Codecov Report
@@ Coverage Diff @@
## master #6702 +/- ##
==========================================
- Coverage 83.9% 83.59% -0.32%
==========================================
Files 668 668
Lines 37687 37720 +33
==========================================
- Hits 31622 31532 -90
- Misses 6065 6188 +123
Continue to review full report at Codecov.
|
a08663a to
3e30d44
Compare
airflow/models/baseoperator.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is this helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only when the dag has never been set. We could also throw an exception here (or assert :)), but I think returning empty set is a better choice (because no Dag has no relative ids :D).
With MyPy we now detect many places where None'able (i.e. Optional) field is used to call a method which is great because it really avoids having a mysterious errors during development.
3e30d44 to
8ef99cc
Compare
8ef99cc to
7a981bb
Compare
|
Hey @kaxil - re-reviewed and corrected. Pls take a look . |
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. It was for debugging of a problem. Will revert.
feluelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 (after you revert the AIRFLOW_CI_SILENT change)
7a981bb to
3669652
Compare
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation