Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Feb 2, 2020

# -*- coding: utf-8 -*- is a Python 2 thing. In Python 3+, the default encoding of source files is UTF-8 and that line is useless. In the next PR, I want to introduce automatic checking using pre-commit to avoid regression.


Issue link: AIRFLOW-6714

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

Codecov Report

Merging #7338 into master will increase coverage by 52.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7338       +/-   ##
===========================================
+ Coverage   32.86%   85.82%   +52.96%     
===========================================
  Files         867      867               
  Lines       40560    40560               
===========================================
+ Hits        13331    34812    +21481     
+ Misses      27229     5748    -21481
Impacted Files Coverage Δ
...low/contrib/operators/wasb_delete_blob_operator.py 100% <ø> (+100%) ⬆️
...rflow/contrib/hooks/gcp_video_intelligence_hook.py 100% <ø> (+100%) ⬆️
airflow/contrib/hooks/vertica_hook.py 100% <ø> (+100%) ⬆️
...irflow/example_dags/example_kubernetes_executor.py 85% <ø> (ø) ⬆️
...ample_dags/example_branch_python_dop_operator_3.py 75% <ø> (ø) ⬆️
airflow/contrib/utils/weekday.py 100% <ø> (+25%) ⬆️
...irflow/contrib/operators/redis_publish_operator.py 100% <ø> (+100%) ⬆️
airflow/contrib/hooks/qubole_hook.py 100% <ø> (+100%) ⬆️
airflow/contrib/sensors/qubole_sensor.py 100% <ø> (+100%) ⬆️
airflow/contrib/utils/gcp_field_sanitizer.py 0% <ø> (ø) ⬆️
... and 1067 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf14150...87d54c9. Read the comment docs.

@mik-laj mik-laj merged commit 97a429f into apache:master Feb 2, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants