[AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax #7343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:Scheduler
Member
Author
|
The first build is unlikely to be valid because pyupgrade introduces changes incompatible with flake8, but I want to check it on CI. |
6 tasks
mik-laj
force-pushed
the
AIRFLOW-6719-pyupgrade
branch
2 times, most recently
from
b18ba32 to
918a3e5
Compare
mik-laj
force-pushed
the
AIRFLOW-6719-pyupgrade
branch
from
918a3e5 to
33c69ab
Compare
zhongjiajie
reviewed
Feb 27, 2020
Comment on lines
+77
to
+89
| <<<<<<< HEAD | ||
| s3_hook.delete_objects(bucket=self.bucket, keys=self.keys) | ||
| ======= | ||
|
|
||
| response = s3_hook.delete_objects(bucket=self.bucket, keys=self.keys) | ||
|
|
||
| deleted_keys = [x['Key'] for x in response.get("Deleted", [])] | ||
| self.log.info("Deleted: %s", deleted_keys) | ||
|
|
||
| if "Errors" in response: | ||
| errors_keys = [x['Key'] for x in response.get("Errors", [])] | ||
| raise AirflowException(f"Errors when deleting: {errors_keys}") | ||
| >>>>>>> b18ba328b... [AIRFLOW-6719] Introduce pyupgrade to enforce latest syntax |
Member
There was a problem hiding this comment.
It fail as you said, not that easy, but this is rebase mistake
| ssh_hook=self.hook, | ||
| command="echo '{0}' > {1}".format(test_remote_file_content, | ||
| command="echo '{}' > {}".format(test_remote_file_content, | ||
| self.sftp_path), |
Member
There was a problem hiding this comment.
Suggested change
| self.sftp_path), | |
| self.sftp_path), |
tests/providers/amazon/aws/operators/test_sftp_to_s3.py:85:47: E127 continuation line over-indented for visual indent
tests/models/test_taskinstance.py:318:45: E128 continuation line under-indented for visual indent
airflow/ti_deps/deps/runnable_exec_date_dep.py:38:47: E127 continuation line over-indented for visual indent
tests/providers/sftp/operators/test_sftp.py:214:47: E127 continuation line over-indented for visual indent
tests/providers/sftp/operators/test_sftp.py:252:47: E127 continuation line over-indented for visual indent
tests/providers/sftp/operators/test_sftp.py:291:47: E127 continuation line over-indented for visual indent
tests/providers/sftp/operators/test_sftp.py:327:47: E127 continuation line over-indented for visual indent
airflow/cli/commands/dag_command.py:85:50: E127 continuation line over-indented for visual indent
airflow/ti_deps/deps/dag_ti_slots_available_dep.py:33:57: E127 continuation line over-indented for visual indent
airflow/providers/sftp/operators/sftp.py:139:57: E127 continuation line over-indented for visual indent
airflow/providers/sftp/operators/sftp.py:150:57: E127 continuation line over-indented for visual indent
airflow/ti_deps/deps/not_in_retry_period_dep.py:52:41: E127 continuation line over-indented for visual indent
Member
Author
|
@zhongjiajie I don't have time to finish this, because I've taken care of the scheduler performance. Would you like to take over? |
Member
|
@mik-laj Sure, but how could I do? submit a new PR to this repo? or create a PR to PolideaInternal:AIRFLOW-6719-pyupgrade? |
Member
Author
|
@mik-laj please create new PR to apache/airflow but reuse JIRA number. |
6 tasks
Member
|
Closed in favour of #7573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people love the latest syntax, so I would like to introduce it automatically for the project. These are mainly fstring changes, but not only.
Issue link: AIRFLOW-6719
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.