[AIRFLOW-6721] [WIP] Organize hive tests #7442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good direction. I look forward to further work. |
coopergillan
force-pushed
the
AIRFLOW-6721-organize-hive-tests
branch
3 times, most recently
from
683a93f to
86d855e
Compare
Move the WebHdfsSensor tests out of the operator tests and into a separate module.
Movee the TestHiveEnvironment class and setUp method out to the hive test module so that it can be used in other hive tests.
Move skipped test for HiveStatsCollectionOperator to the test_hive_stats module to make it easier to locate.
Move the NamedHivePartitionSensor tests from the operators module into the test module for NamedHivePartitionSensor.
Move the HivePartitionSensor tests from the operators module into the a new test module.
Move the HiveToMySqlTransfer test in the operators module into the existing test module and use the shared test environment for these tests.
Move the HdfsSensor test in the operators module into a new test module and use the shared test environment.
Move the Hive2SambaOperator test in the operators module into the existing test module and use the shared test environment.
Move the MetastorePartitionSensor test from the operators module into a new module and use the shared test environment.
Move the PrestoToMySqlTransfer test from the operators module into an existing test module and use shared Hive test environment.
Move the PrestoCheckOperator test from the Hive operators module into a new Presto operators test module while still using the shared Hive test environment.
Move the SqlSensor in the Hive operators module into the existing SqlSensor test module and label it as such. Use the shared test environment for all tests, ensuring that original setUp properties are preserved for the existing tests.
coopergillan
force-pushed
the
AIRFLOW-6721-organize-hive-tests
branch
from
f2d24ad to
1846cc9
Compare
Contributor
Author
|
Closing in favor of non-draft PR: #7468 |
Contributor
Author
|
There were some strange transient issues with github so I opened another PR on a nearly identcal branch over in #7468. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEST REVIEWED COMMIT-BY-COMMIT
This is a work in progress. Looking for any feedback on the approach and can finish the work after. Thanks!
@mik-laj
Issue link: AIRFLOW-6721
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.