[AIRFLOW-6867] Decouple DagBag and TaskInstance #7488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
potiuk
approved these changes
Feb 21, 2020
ashb
reviewed
Feb 21, 2020
| CYCLE_DONE = 2 | ||
| DAGBAG_IMPORT_TIMEOUT = conf.getint('core', 'DAGBAG_IMPORT_TIMEOUT') | ||
| UNIT_TEST_MODE = conf.getboolean('core', 'UNIT_TEST_MODE') | ||
| SCHEDULER_ZOMBIE_TASK_THRESHOLD = conf.getint('scheduler', 'scheduler_zombie_task_threshold') |
Member
There was a problem hiding this comment.
Is this still needed in here? Feels like it shouldn't be
Member
Author
There was a problem hiding this comment.
I don't know. I just do simple refactoring. I don't know the history of this option.
Codecov Report
@@ Coverage Diff @@
## master #7488 +/- ##
==========================================
- Coverage 86.68% 86.46% -0.23%
==========================================
Files 882 883 +1
Lines 41526 41634 +108
==========================================
+ Hits 35997 35998 +1
- Misses 5529 5636 +107
Continue to review full report at Codecov.
|
Contributor
|
@mik-laj there is typo Simpley |
Member
Author
|
@tooptoop4 Thanks. I will try to correct all types in the schedule when I finish optimizing the scheduler. |
ashb
added a commit
to ashb/airflow
that referenced
this pull request
Feb 25, 2020
The refactor in apache#7488 introduced a scheduler-breaking bug.
6 tasks
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DagBag should be responsible for loading DAGs. The Scheduler should be responsible for managing task instance.
Issue link: AIRFLOW-6867
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.