Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Mar 18, 2020

When we have custom executors and operators loaded using the operators property in plugins to avoid loading classes in the scheduler, operators are still loaded. After this change, the properties will be read only when needed.


Issue link: AIRFLOW-7084

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:plugins area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues labels Mar 18, 2020
@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #7758 into master will decrease coverage by 0.05%.
The diff coverage is 88.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7758      +/-   ##
==========================================
- Coverage   86.98%   86.93%   -0.06%     
==========================================
  Files         915      920       +5     
  Lines       44228    44499     +271     
==========================================
+ Hits        38473    38685     +212     
- Misses       5755     5814      +59     
Impacted Files Coverage Δ
airflow/serialization/serialized_objects.py 90.09% <66.66%> (-0.52%) ⬇️
airflow/models/baseoperator.py 95.68% <80.00%> (-0.37%) ⬇️
airflow/plugins_manager.py 88.58% <90.78%> (-1.56%) ⬇️
airflow/www/app.py 94.28% <100.00%> (ø)
...le_dags/example_passing_params_via_test_command.py 100.00% <0.00%> (ø)
...rflow/providers/google/firebase/hooks/firestore.py 97.29% <0.00%> (ø)
.../google/firebase/example_dags/example_firestore.py 100.00% <0.00%> (ø)
.../providers/google/cloud/operators/presto_to_gcs.py 38.66% <0.00%> (ø)
...google/cloud/example_dags/example_presto_to_gcs.py 100.00% <0.00%> (ø)
...w/providers/google/firebase/operators/firestore.py 95.65% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73305c7...d805f04. Read the comment docs.

@mik-laj mik-laj merged commit c24f841 into apache:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugins area:Scheduler including HA (high availability) scheduler area:serialization area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants