Skip to content

Fix example DAG for MLEngine in backport package #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mik-laj merged 1 commit into from
Mar 25, 2020
Merged

Fix example DAG for MLEngine in backport package #7813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions backport_packages/setup_backport_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ def run(self):
def change_import_paths_to_deprecated():
from bowler import LN, TOKEN, Capture, Filename, Query
from fissix.pytree import Leaf
from fissix.fixer_util import KeywordArg, Name, Comma
from bowler import BowlerTool

def remove_tags_modifier(node: LN, capture: Capture, filename: Filename) -> None:
for node in capture['function_arguments'][0].post_order():
Expand All @@ -161,6 +163,14 @@ def remove_super_init_call(node: LN, capture: Capture, filename: Filename) -> No
if any(c.value for c in ch.parent.post_order() if isinstance(c, Leaf)):
ch.parent.remove()

def add_provide_context_to_python_operator(node: LN, capture: Capture, filename: Filename) -> None:
fn_args = capture['function_arguments'][0]
fn_args.append_child(Comma())

provide_context_arg = KeywordArg(Name('provide_context'), Name('True'))
provide_context_arg.prefix = fn_args.children[0].prefix
fn_args.append_child(provide_context_arg)

changes = [
("airflow.operators.bash", "airflow.operators.bash_operator"),
("airflow.operators.python", "airflow.operators.python_operator"),
Expand All @@ -174,9 +184,9 @@ def remove_super_init_call(node: LN, capture: Capture, filename: Filename) -> No
# Move and refactor imports for Dataflow
copyfile(
os.path.join(dirname(__file__), os.pardir, "airflow", "utils", "python_virtualenv.py"),
os.path.join(dirname(__file__), "airflow", "providers",
"google", "cloud", "utils", "python_virtualenv.py"
)
os.path.join(
dirname(__file__), "airflow", "providers", "google", "cloud", "utils", "python_virtualenv.py"
)
)
(
qry
Expand All @@ -185,9 +195,9 @@ def remove_super_init_call(node: LN, capture: Capture, filename: Filename) -> No
)
copyfile(
os.path.join(dirname(__file__), os.pardir, "airflow", "utils", "process_utils.py"),
os.path.join(dirname(__file__), "airflow", "providers",
"google", "cloud", "utils", "process_utils.py"
)
os.path.join(
dirname(__file__), "airflow", "providers", "google", "cloud", "utils", "process_utils.py"
)
)
(
qry
Expand All @@ -212,6 +222,13 @@ def remove_super_init_call(node: LN, capture: Capture, filename: Filename) -> No
# Fix super().__init__() call in hooks
qry.select_subclass("BaseHook").modify(remove_super_init_call)

(
qry.select_function("PythonOperator")
.is_call()
.is_filename(include=r"mlengine_operator_utils.py$")
.modify(add_provide_context_to_python_operator)
)

qry.execute(write=True, silent=False, interactive=False)


Expand Down