Skip to content

Conversation

@auvipy
Copy link
Contributor

@auvipy auvipy commented Jun 24, 2020


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@auvipy
Copy link
Contributor Author

auvipy commented Jun 24, 2020

this release fixes some regression.

@turbaszek
Copy link
Member

@kaxil @potiuk should we merge or run all tests?

@potiuk
Copy link
Member

potiuk commented Jun 29, 2020

Yeah. Adding an artificial plugin change for now should do the trick. Alternatively (And possibly better) add requirements/* to the regexp here; https://github.com/apache/airflow/blob/master/.github/workflows/ci.yml#L169

@turbaszek
Copy link
Member

turbaszek commented Jul 6, 2020

@auvipy once this one #9690 is merged will you be able to rebase?

@auvipy
Copy link
Contributor Author

auvipy commented Jul 6, 2020

sure just ping me

@turbaszek
Copy link
Member

@auvipy would you mind rebasing?

@auvipy
Copy link
Contributor Author

auvipy commented Jul 21, 2020

do we need that? it's showing all are passing

@turbaszek
Copy link
Member

do we need that? it's showing all are passing

Only static checks has passed. To optimize the builds we do not run tests with "docs" changes. That was fixed in #9690

@auvipy auvipy closed this Jul 21, 2020
@auvipy auvipy reopened this Jul 21, 2020
@turbaszek turbaszek requested a review from potiuk August 3, 2020 11:16
Copy link
Contributor Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the mean time, I released another bug fix release of celery==4.4.7

auvipy and others added 2 commits August 3, 2020 19:21
@turbaszek turbaszek merged commit dd2dec0 into apache:master Aug 4, 2020
@auvipy auvipy deleted the patch-1 branch August 12, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants