Skip to content

Conversation

@turbaszek
Copy link
Member

The method should submit the job and wait for the result.
Closes: #9897


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Jul 20, 2020
The method should submit the job and wait for the result.
Closes: apache#9897
@turbaszek turbaszek force-pushed the fix-insert-job-method-bq branch from 78acdca to 35e6f26 Compare July 20, 2020 17:51
@nathadfield
Copy link
Collaborator

nathadfield commented Jul 20, 2020

@turbaszek Ah! You beat me to the fix!

@potiuk
Copy link
Member

potiuk commented Jul 20, 2020

So looks like indeed new backport package release is around the corner.

@turbaszek turbaszek added this to the Backport packages 2 milestone Jul 20, 2020
@turbaszek
Copy link
Member Author

I run system tests using changes from #9909 and everything seems to work as expected

@turbaszek turbaszek marked this pull request as ready for review July 21, 2020 09:42
@turbaszek turbaszek requested review from mik-laj and potiuk July 21, 2020 09:42
@turbaszek
Copy link
Member Author

FYI @olchas

@turbaszek turbaszek merged commit 1cfdebf into apache:master Jul 21, 2020
@turbaszek turbaszek deleted the fix-insert-job-method-bq branch July 21, 2020 10:16
@nathadfield
Copy link
Collaborator

nathadfield commented Jul 21, 2020

So looks like indeed new backport package release is around the corner.

Definitely! Especially because of this too.

#9900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQueryToGCSOperator doesn't seem to do anything

4 participants