AMBARI-25993: logsearch-logfeeder cannot startup due to lake of configuration #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cloud.storage.mode
JiaLiangC
reviewed
Jul 27, 2024
| } | ||
| } | ||
| } catch (IllegalArgumentException e) { | ||
| return LogFeederMode.DEFAULT; |
There was a problem hiding this comment.
@rzuo Can we add some logging here to indicate this configuration exception and the fallback to using the default configuration? This would help users troubleshoot issues more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
logsearch-logfeeder fail to startup and report:
java.lang.IllegalArgumentException: String 'null' cannot be converted to LogFeederMode enum
Due to the lake of configuration item logfeeder.cloud.storage.mode in configuration.
We need to fall back to Default("default") without this configuration, so logfeeder can startup normally.
After the fix, logfeeder startup normally, and can feed log data to logsearch-portal.
How was this patch tested?
local install and test this fix in local cluster.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.