Skip to content

Conversation

@majin1102
Copy link
Contributor

@majin1102 majin1102 commented Jan 24, 2026

Why are the changes needed?

New feature:

  1. Introduce a Local storage type to leverage AMS local path as catalog
  2. Unify Internal catalog type as a metastore
  3. Use backend API to control table format list and storage types which is:
export function getMetastoreTableFormats(type: string) {
  return request.get(`api/ams/v1/catalogs/metastore/${type}/table-formats`)
}
export function getMetastoreStorageTypes(type: string) {
  return request.get(`api/ams/v1/catalogs/metastore/${type}/storage-types`)

Fix:

  1. Storage type don't refresh(stays in a selection shouldn't exist) when metastore changes in catalog creation page
  2. Fix select a table first time the table details don't render bug
  3. Table explorer database would be rendered as a leaf node(see page below, the right rendation is afterwards) if it is empty
image image

Brief change log

How was this patch tested?

  1. Create a local Iceberg catalog(with the new storage type Local)
  2. Run SQL in terminal in that catalog(create database, create table, write data)
  3. The fix has been checked

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

majin.nathan added 2 commits January 25, 2026 02:44
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 3.57143% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.43%. Comparing base (cbdc517) to head (3106fcd).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
.../main/java/org/apache/amoro/utils/CatalogUtil.java 0.00% 75 Missing ⚠️
...in/java/org/apache/amoro/CommonUnifiedCatalog.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4060      +/-   ##
============================================
+ Coverage     22.12%   22.43%   +0.30%     
- Complexity     2461     2554      +93     
============================================
  Files           445      457      +12     
  Lines         40897    42092    +1195     
  Branches       5767     5917     +150     
============================================
+ Hits           9050     9442     +392     
- Misses        31089    31838     +749     
- Partials        758      812      +54     
Flag Coverage Δ
trino 22.43% <3.57%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Aireed Aireed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majin1102 majin1102 merged commit f5b0ac5 into apache:master Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants