glib: issue installing with Homebrew

[lidavidm]

What happened?

@amoeba reports an issue with installing/testing GLib with Arrow installed via Homebrew:

glib/adbc-arrow-glib/meson.build:115:37: ERROR: Could not get pkg-config variable and no default provided for <PkgConfigDependency arrow-glib: True None>

It seems the formula no longer installs with -Dvapi=true and that installing the package with that option enabled again allows verification to proceed.

Stack Trace

No response

How can we reproduce the bug?

No response

Environment/Setup

macOS, Homebrew, M1

[kou]

Does this happen in RC verification? Or in a general test?

[amoeba]

I've only run into this while verifying the last RC, partial log at https://gist.github.com/amoeba/d45f131498743851380cc7a9fca5cd49.

[kou]

OK. Let's improve Vala availability detection:

arrow-adbc/ci/scripts/glib_build.sh

Line 41 in 9a10e67

if type valac > /dev/null 2>&1; then

Something like:

diff --git a/ci/scripts/glib_build.sh b/ci/scripts/glib_build.sh
index fdc1276f4..64255d8dd 100755
--- a/ci/scripts/glib_build.sh
+++ b/ci/scripts/glib_build.sh
@@ -38,7 +38,8 @@ build_subproject() {
         cmake_prefix_path="${CONDA_PREFIX}:${cmake_prefix_path}"
         pkg_config_path="${pkg_config_path}:${CONDA_PREFIX}/lib/pkgconfig"
     fi
-    if type valac > /dev/null 2>&1; then
+    if type valac > /dev/null 2>&1 && \
+            [[ -n "$(pkg-config --variable=vapidir arrow-glib)" ]]; then
         enable_vapi=true
     else
         enable_vapi=false