feat(go/adbc/driver/flightsql): Build C shared lib for flightsql adbc driver #347
Conversation
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, just some nits about unprefixed exported functions.
I guess the next follow up would be to set up CI to run this driver against the C++ test suite and see what happens. For that, I think it would be good if there were some standalone Flight SQL server example we could use...probably the Go one is easiest just in terms of building it.
zeroshade
force-pushed
the
flightsql-dynlib
branch
from
3086181 to
e4511eb
Compare
zeroshade
force-pushed
the
flightsql-dynlib
branch
from
71fed32 to
4d5f817
Compare
zeroshade
changed the title
zeroshade
force-pushed
the
flightsql-dynlib
branch
from
3a45b8f to
935c858
Compare
| return out, nil | ||
| } | ||
|
|
||
| func formatCSource(in []byte) ([]byte, error) { |
There was a problem hiding this comment.
pre-commit would just take care of this for you, though I guess it requires a little setup.
There was a problem hiding this comment.
how do i get pre-commit to actually fix the things instead of just failing the check? lol
There was a problem hiding this comment.
If you have it locally, pre-commit run [--all-files] will fix up the files for you, then you can stage and commit
lidavidm
changed the title
2 participants
Creates a framework for generating standalone packaged ADBC drivers as .so shared libraries which can be easily distributed out of Go's implementation.