refactor(c): Use ArrowArrayViewListChildOffset from nanoarrow #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
May 22, 2023
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Thanks!
We should delete the old definition presumably?
Contributor
Author
|
Yep thanks for that - oversight on my end |
lidavidm
approved these changes
May 22, 2023
| return ""; | ||
| } | ||
|
|
||
| int64_t ArrowArrayViewGetOffsetUnsafe(struct ArrowArrayView* array_view, int64_t i) { |
Member
There was a problem hiding this comment.
Should also be removed from adbc_validation_util.h
lidavidm
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #679 (comment) this pulls down the nanoarrow change apache/arrow-nanoarrow#197