GH-3: Enable CI #17
Closed
GH-3: Enable CI #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've created an empty License and Notice files to bypass CI requirements. We should wait for: and remove the temporary files. |
Member
Author
|
Last CI run on my fork: |
Member
|
I've merged #12 to unblock this. |
kou
reviewed
May 20, 2025
Member
There was a problem hiding this comment.
Could you use recommended compose.yaml (not .yml) file name for Docker Compose v2?
See also: https://docs.docker.com/compose/gettingstarted/#step-2-define-services-in-a-compose-file
| name: ${ARCH}-debian-${DEBIAN}-ccache | ||
|
|
||
| services: | ||
| debian-js: |
Member
There was a problem hiding this comment.
Suggested change
| debian-js: | |
| debian: |
Comment on lines
+29
to
+30
| debian-ccache: | ||
| name: ${ARCH}-debian-${DEBIAN}-ccache |
Member
There was a problem hiding this comment.
We don't need to use ccache. We want to use jest instead:
Suggested change
| debian-ccache: | |
| name: ${ARCH}-debian-${DEBIAN}-ccache | |
| jest-cache: | |
| name: jest-cache |
Merged
Member
Author
|
I am closing this in favor of: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CI. Move https://github.com/apache/arrow/blob/main/.github/workflows/js.yml to this repository.
Closes #3