Bump CategoricalArrays to 1.0 in tests #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix test failures from apache#556.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 87.43% 87.37% -0.07%
==========================================
Files 26 27 +1
Lines 3288 3383 +95
==========================================
+ Hits 2875 2956 +81
- Misses 413 427 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quinnj
approved these changes
Jan 14, 2026
Member
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Ah yeah, sorry, I should have noticed the PR age. I saw all green and just went ahead and merged. I'll take a look other failing CI issues.
Contributor
Author
|
Mmm there still seem to be failures related to CategoricalArrays. :-/ |
Member
|
I think I have a fix; I'll push here |
nalimilan
commented
Jan 14, 2026
- Restore Apache License header in Project.toml that was accidentally removed by CompatHelper bot in PR apache#536 - Update test/Project.toml ArrowTypes compat to 2.3 which includes the fix for offset array handling in ToArrow needed for CategoricalArrays 1.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ArrowTypes 2.3.0 in the registry doesn't include the offset array fix from PR apache#556. The fix is in the local src/ArrowTypes/ but hasn't been released yet. Update CI and release verification to use Pkg.develop to use the local ArrowTypes instead of the registry version. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Ah yes thanks now I remember I had to hack ArrowTypes locally to get it to be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix test failures from #556.