Skip to content

Add binary_mut and try_binary_mut#3144

Merged
tustvold merged 7 commits intoapache:masterfrom
viirya:add_mut
Nov 30, 2022
Merged

Add binary_mut and try_binary_mut#3144
tustvold merged 7 commits intoapache:masterfrom
viirya:add_mut

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented Nov 19, 2022

Which issue does this PR close?

Closes #3143.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 19, 2022
tustvold
tustvold reviewed Nov 21, 2022
View reviewed changes
Comment thread arrow/src/compute/kernels/arity.rs
a: PrimitiveArray<T>,
b: &PrimitiveArray<T>,
op: F,
) -> std::result::Result<
Copy link
Copy Markdown
Contributor

@tustvold tustvold Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on #3134 I think this Result should be the other way round

doki23
doki23 reviewed Nov 24, 2022
View reviewed changes
Comment thread arrow/src/compute/kernels/arity.rs
doki23
doki23 reviewed Nov 24, 2022
View reviewed changes
Comment thread arrow/src/compute/kernels/arity.rs
viirya
viirya commented Nov 28, 2022
View reviewed changes
Comment thread arrow/src/compute/kernels/arity.rs
/// This function gives error if the arrays have different lengths.
/// This function gives error of original [`PrimitiveArray`] `a` if it is not a mutable
/// primitive array.
pub fn binary_mut<T, F>(
Copy link
Copy Markdown
Member Author

@viirya viirya Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I will leave this only and remove _mut kernels.

@viirya viirya changed the title Add add_mut and add_checked_mut Add binary_mut and try_binary_mut Nov 29, 2022
@tustvold tustvold merged commit 961e114 into apache:master Nov 30, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Nov 30, 2022

Benchmark runs are scheduled for baseline = 989ab8d and contender = 961e114. 961e114 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced May 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold approved these changes

+1 more reviewer

@doki23 doki23 doki23 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add binary_mut and try_binary_mut

4 participants

@viirya @ursabot @tustvold @doki23