make sure that only concat preallocates buffers

[ritchie46]

Which issue does this PR close?

Partial fix for #347. In #348 @jorgecarleitao pointed out that the memory savings don't work for the filter and the zip kernel.
This PR restores the implementation for those two kernels, and keeps the new preallocation for the concat kernel.

This is achieved by create a builder pattern for MutableArrayData. This way we don't break the API, and we may choose to preallocate buffers.

Could you take a look at this @jorgecarleitao ?

Are there any user-facing changes?

There is an builder pattern struct for MutableArrayData.

If there are any breaking changes to public APIs, please add the breaking change label.

No

[codecov-commenter]

Codecov Report

Merging #382 (531a5f3) into master (4ff2e56) will decrease coverage by 0.04%.
The diff coverage is 59.45%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   82.61%   82.57%   -0.05%     
==========================================
  Files         162      162              
  Lines       44228    44280      +52     
==========================================
+ Hits        36538    36563      +25     
- Misses       7690     7717      +27     

Impacted Files	Coverage Δ
arrow/src/array/transform/mod.rs	85.97% <49.15%> (-3.22%)	⬇️
arrow/src/compute/kernels/concat.rs	100.00% <100.00%> (ø)
parquet/src/encodings/encoding.rs	94.85% <0.00%> (-0.20%)	⬇️
arrow/src/array/transform/boolean.rs	84.61% <0.00%> (+7.69%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff2e56...531a5f3. Read the comment docs.

[jorgecarleitao]

Thanks @ritchie46 . My small concerns with this PR:

1. We are introducing yet another builder API for something relatively easy to accomplish with an extra method
2. preallocate_buffers assumes that "preallocate" means allocate the maximum possible capacity, which IMO is not really pre-allocating, is just being very conservative and allocating the maximum.
3. The API is rather limited to the concatenate case.

I left some ideas as a comment on the issue

[ritchie46]

@jorgecarleitao I implemented your proposal from #347. As we now need to define an enum in the with_capacities constructor, I want to be extra certain that I added all possible variants, as adding one later is backwards incompatable. Could you check if I missed something.

For now, only the (large)-utf8 ones uses this, but if the design is ok, I can add more in later PRs.

[alamb]

@jorgecarleitao what is the status of this one?

[jorgecarleitao]

Good to go: this is a solid improvement to me.

[alamb]

Included in #411 cherry pick