Fix bug with null buffer offset in boolean not kernel #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 162 162
Lines 44479 44487 +8
=======================================
+ Hits 36750 36759 +9
+ Misses 7729 7728 -1
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 7, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @jhorstmann 👍
| } | ||
|
|
||
| #[test] | ||
| fn test_bool_array_not_sliced() { |
Contributor
There was a problem hiding this comment.
For anyone interested, without the code change this test fails in the following way:
---- compute::kernels::boolean::tests::test_bool_array_not_sliced stdout ----
thread 'compute::kernels::boolean::tests::test_bool_array_not_sliced' panicked at 'assertion failed: ceil(offset + len, 8) <= buffer.len() * 8', arrow/src/util/bit_chunk_iterator.rs:33:9
failures:
compute::kernels::boolean::tests::test_bool_array_not_sliced
Contributor
|
FYI @jorgecarleitao |
alamb
pushed a commit
that referenced
this pull request
Jun 8, 2021
alamb
added a commit
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #417.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
No