Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Jun 9, 2021

Which issue does this PR close?

based on #424
Closes #437

Rationale for this change

use iterator for partition kernel instead of generating vec

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #438 (e0f05a0) into master (0c00776) will decrease coverage by 0.00%.
The diff coverage is 92.50%.

❗ Current head e0f05a0 differs from pull request most recent head 9d11166. Consider uploading reports for the commit 9d11166 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   82.71%   82.70%   -0.01%     
==========================================
  Files         163      163              
  Lines       44795    44791       -4     
==========================================
- Hits        37051    37045       -6     
- Misses       7744     7746       +2     
Impacted Files Coverage Δ
arrow/src/compute/kernels/partition.rs 97.50% <92.50%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c00776...9d11166. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jun 9, 2021

Looks like this PR needs a rebase.

@jimexist jimexist force-pushed the partition-iter branch 2 times, most recently from f50e574 to 9d11166 Compare June 9, 2021 23:37
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me. 👍 @jimexist

@alamb
Copy link
Contributor

alamb commented Jun 10, 2021

FYI @jorgecarleitao

@alamb alamb added the api-change Changes to the arrow API label Jun 12, 2021
@alamb alamb merged commit e21f576 into apache:master Jun 13, 2021
@jimexist jimexist deleted the partition-iter branch June 13, 2021 10:58
@alamb alamb added arrow Changes to the arrow crate api-change Changes to the arrow API and removed api-change Changes to the arrow API labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate partition kernel to use Iterator trait

3 participants