Skip to content

Conversation

@PsiACE
Copy link
Member

@PsiACE PsiACE commented Jul 18, 2021

Which issue does this PR close?

Closes #561 .

Rationale for this change

audit vulnerable: https://rustsec.org/advisories/RUSTSEC-2021-0073

What changes are included in this PR?

  • Try to bump prost and tonic .
  • Make filter::prep_null_mask_filter public

Are there any user-facing changes?

public filter::prep_null_mask_filter

PsiACE added 2 commits July 17, 2021 21:55
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Jul 18, 2021
Signed-off-by: Chojan Shang <psiace@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Merging #560 (fe32115) into master (f873d77) will decrease coverage by 0.02%.
The diff coverage is 1.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   82.47%   82.45%   -0.03%     
==========================================
  Files         167      167              
  Lines       46144    46158      +14     
==========================================
  Hits        38059    38059              
- Misses       8085     8099      +14     
Impacted Files Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs 0.00% <0.00%> (ø)
arrow/src/compute/kernels/filter.rs 91.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f873d77...fe32115. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @PsiACE

@alamb alamb merged commit 42400fd into apache:master Jul 19, 2021
alamb pushed a commit that referenced this pull request Jul 19, 2021
* Update tonic and prost

Signed-off-by: Chojan Shang <psiace@outlook.com>

* Make filter::prep_null_mask_filter public

Signed-off-by: Chojan Shang <psiace@outlook.com>

* Bump prost and tonic in integration-testing

Signed-off-by: Chojan Shang <psiace@outlook.com>
alamb added a commit that referenced this pull request Jul 20, 2021
* Update tonic and prost

Signed-off-by: Chojan Shang <psiace@outlook.com>

* Make filter::prep_null_mask_filter public

Signed-off-by: Chojan Shang <psiace@outlook.com>

* Bump prost and tonic in integration-testing

Signed-off-by: Chojan Shang <psiace@outlook.com>

Co-authored-by: Chojan Shang <psiace@ritelabs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo audit failed

3 participants