feat: impl *Assign ops for types in arrow-buffer#5832
feat: impl *Assign ops for types in arrow-buffer#5832tustvold merged 3 commits intoapache:masterfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
I run into this on migrating interval types in datafusion. fn increment_decrement<const INC: bool, T: OneTrait + SubAssign + AddAssign>() |
| bytes = { version = "1.4" } | ||
| num = { version = "0.4", default-features = false, features = ["std"] } | ||
| half = { version = "2.1", default-features = false } | ||
| paste = { version = "1.0" } |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
The failing integration test seems unrelated |
|
I wonder if we could use the I spent some more time trying to document them recently here #5798 |
I don't really follow the connection, these are operations on primitive scalars, not arrays. |
tustvold
left a comment
There was a problem hiding this comment.
I think this is fine, given the types in question are Copy this doesn't make any difference, but is harmless enough
TIL. Those mut-in-place APIs look good. I believe it can help improve UDF/Plan's implementations. As for |
|
By the way, I noticed that |
|
Good spot, I thought I had fixed that, but guess I forgot - #5837 |
Which issue does this PR close?
Closes #.
Rationale for this change
Impl
std::ops::*Assign(likeAddAssign) fori256,IntervalDayTimeandIntervalMonthDayNano.What changes are included in this PR?
The first commit (95da017) contains the plain implementation of
AddAssignandSubAssignas examplesAre there any user-facing changes?
Yes