Minor: make it clear Predicate is crate private#7001
Merged
tustvold merged 1 commit intoapache:mainfrom Jan 22, 2025
Merged
Conversation
4df9a72 to
7d3d6a3
Compare
Contributor
Author
|
Thank you @tustvold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Binaryarrays instarts_with,ends_withandcontains#6926Rationale for this change
Predicateis markedpubbut it is in a non public modulearrow-rs/arrow-string/src/lib.rs
Line 24 in 595a835
This gives it a false impression that it is part of the public API, which it is not:
What changes are included in this PR?
Mark
pub(crate)to make it explicit that this structure is not public outside the crateAre there any user-facing changes?