Skip to content

Minor: make it clear Predicate is crate private#7001

Merged
tustvold merged 1 commit intoapache:mainfrom
alamb:add-example-arrow-binary-crate
Jan 22, 2025
Merged

Minor: make it clear Predicate is crate private#7001
tustvold merged 1 commit intoapache:mainfrom
alamb:add-example-arrow-binary-crate

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Jan 21, 2025

Which issue does this PR close?

Rationale for this change

Predicate is marked pub but it is in a non public module

mod predicate;

This gives it a false impression that it is part of the public API, which it is not:

What changes are included in this PR?

Mark pub(crate) to make it explicit that this structure is not public outside the crate

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jan 21, 2025
@alamb alamb force-pushed the add-example-arrow-binary-crate branch from 4df9a72 to 7d3d6a3 Compare January 22, 2025 13:41
@alamb alamb marked this pull request as ready for review January 22, 2025 13:41
@tustvold tustvold merged commit 1664214 into apache:main Jan 22, 2025
@alamb alamb deleted the add-example-arrow-binary-crate branch January 22, 2025 17:14
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Jan 22, 2025

Thank you @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants