Add is_valid and truncate methods to NullBufferBuilder#7013
Merged
alamb merged 14 commits intoapache:mainfrom Jan 27, 2025
Merged
Add is_valid and truncate methods to NullBufferBuilder#7013alamb merged 14 commits intoapache:mainfrom
is_valid and truncate methods to NullBufferBuilder#7013alamb merged 14 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7002 .
Rationale for this change
As #7002 says, some required methods are implemented due to the need to replace
BooleanBufferBuilderwithNullBufferBuilderin DataFsusion.What changes are included in this PR?
capacity()is_valid()(as same asget_bit()inBooleanBufferBuilder)truncate()Are there any user-facing changes?