Skip to content

Fix requirement of object store for http-body-util#7265

Merged
tustvold merged 1 commit intoapache:mainfrom
agourlay:fix-compilation-object-store-http-body-util-version
Mar 11, 2025
Merged

Fix requirement of object store for http-body-util#7265
tustvold merged 1 commit intoapache:mainfrom
agourlay:fix-compilation-object-store-http-body-util-version

Conversation

@agourlay
Copy link
Copy Markdown
Contributor

@agourlay agourlay commented Mar 11, 2025

Fix the compilation of the object store due to incorrect requirement.

When updating to object-store 0.12.0, I ran into a crate compilation failure.

error[E0599]: no method named `into_data_stream` found for struct `BoxBody` in the current scope
   --> /home/agourlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/object_store-0.12.0/src/client/body.rs:176:24
    |
176 |         let s = self.0.into_data_stream();
    |                        ^^^^^^^^^^^^^^^^
    |
help: there is a method `into_raw` with a similar name
    |
176 |         let s = self.0.into_raw();
    |                        ~~~~~~~~

error[E0599]: no method named `into_data_stream` found for struct `BoxBody` in the current scope
   --> /home/agourlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/object_store-0.12.0/src/client/body.rs:182:16
    |
182 |         self.0.into_data_stream().boxed()
    |                ^^^^^^^^^^^^^^^^
    |
help: there is a method `into_raw` with a similar name
    |
182 |         self.0.into_raw().boxed()
    |                ~~~~~~~~

The method into_data_stream has been introduced in http-body-util in 0.1.2.

Therefore object store needs to have a precise patch version requirement.

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @agourlay

@tustvold
Copy link
Copy Markdown
Contributor

MSRV failure is unrelated - #7271

@tustvold tustvold merged commit b5c2a6e into apache:main Mar 11, 2025
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants