Reapply Box FlightErrror::tonic to reduce size (fixes nightly clippy)#7277
Merged
alamb merged 1 commit intoapache:mainfrom Mar 24, 2025
Merged
Reapply Box FlightErrror::tonic to reduce size (fixes nightly clippy)#7277alamb merged 1 commit intoapache:mainfrom
FlightErrror::tonic to reduce size (fixes nightly clippy)#7277alamb merged 1 commit intoapache:mainfrom
Conversation
…py) (apache#7229)" (apache#7266) This reverts commit f4fde76.
alamb
added
api-change
github-actions
Bot
added
arrow
This was referenced Mar 12, 2025
Contributor
Author
|
main is open for breaking changes, so let's merge this one in |
wiedld
pushed a commit
to influxdata/arrow-rs
that referenced
this pull request
May 21, 2025
…py) (apache#7229)" (apache#7266) (apache#7277) This reverts commit f4fde76.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FlightErrror::tonicto reduce size #7266 / commit f4fde76.Rationale for this change
FlightErrror::tonicto reduce size (fixes nightly clippy) #7229 from @XiangpengHao that contains a breaking API changeFlightErrror::tonicto reduce size #7266Rationale for the original change (from @XiangpengHao):
When working on the nightly rust, I noticed that clippy warns about
FlightErrortoo large, more than 176 bytes.I think it makes sense to keep the error small (32 bytes), as the Result<...> is used in a lot of places.
This PR basically makes
Tonic(tonic::Status)intoTonic(Box<tonic::Status>), which reduces the FlightError from 176 bytes down to 32 bytes.This adds an extra allocation on error, but should probably be fine as it's not on hot path.
What changes are included in this PR?
Are there any user-facing changes?