memory tracking with memory pool #7303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Member
Author
|
cc @jhorstmann @alamb from previous discussion |
Dandandan
approved these changes
Jul 5, 2025
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
I think we should do this.
Contributor
|
I think this is a nice API that could be used for more precise memory tracking in DataFusion (which is really missing at this point). |
Member
Author
|
Thank you @Dandandan, I'm going to merge this tomorrow if there are no other comments ❤️ |
Member
Author
|
Thank you ❤️ |
Contributor
|
🚀 |
Contributor
|
Thanks @waynexia and @Dandandan |
3 tasks
alamb
reviewed
Aug 14, 2025
| [package.metadata.docs.rs] | ||
| all-features = true | ||
|
|
||
| [features] |
Contributor
There was a problem hiding this comment.
Would it be possible to also document this feature flag on the crate page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up of #6590.
Closes #7151.
Rationale for this change
Add
MemoryPoolunderarrow-buffer/poolfeature gate. This pool can implement precise memory tracking for Array/Bytes/MutableBuffer etc. Even in a shared buffer. Design credit to @tustvoldWhat changes are included in this PR?
New feature gate
arrow-buffer/pool.New traits
MemoryPoolandMemoryReservation.New structs
TrackingMemoryPoolwhich implementsMemoryPoolfor tracking memory usage.Corresponding new API
claimforBuffer/MutableBuffer/Bytes.Are there any user-facing changes?
Above new feature and APIs.