Skip to content

Adopt MSRV policy#7314

Merged
alamb merged 5 commits intoapache:mainfrom
psvri:msrv
Mar 27, 2025
Merged

Adopt MSRV policy#7314
alamb merged 5 commits intoapache:mainfrom
psvri:msrv

Conversation

@psvri
Copy link
Copy Markdown
Contributor

@psvri psvri commented Mar 20, 2025 •
edited by alamb
Loading

Which issue does this PR close?

Rationale for this change

Adopt MSRV policy

What changes are included in this PR?

Creating a PR based on the comment #181 (comment) and conversations in that ticket

Are there any user-facing changes?

No

@psvri psvri changed the title Add MSRV policy Adopt MSRV policy Mar 20, 2025
alamb
alamb approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @psvri -- I think this is great. I will also send a note to the mailing list for wider visibility

I think we should wait several days until we merge this PR to give others a chance to comment

@alamb alamb mentioned this pull request Mar 20, 2025
Closed
tustvold
tustvold reviewed Mar 21, 2025
View reviewed changes
Comment thread README.md Outdated
@psvri @tustvold
MInor edits to policy
0c4061b 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
mbrobbel
mbrobbel reviewed Mar 21, 2025
View reviewed changes
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@alamb alamb mentioned this pull request Mar 24, 2025
Closed
psvri and others added 2 commits March 25, 2025 20:11
@psvri @mbrobbel
Apply suggestions from code review
edb71f1 
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
@psvri
Merge branch 'main' into msrv
6cbc158
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 25, 2025

I plan to merge this in 2 days so that it will have been open for a week to allow time for comment

Thanks for driving this to completion @psvri

etseidl
etseidl reviewed Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Comment thread README.md Outdated
@psvri @etseidl
Apply suggestions from code review
f5129f6 
Co-authored-by: Ed Seidl <etseidl@users.noreply.github.com>
@mbrobbel mbrobbel mentioned this pull request Mar 26, 2025
Merged
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 27, 2025

ok, its been open for a week -- let's do this!

@alamb alamb merged commit 2c2e514 into apache:main Mar 27, 2025
9 checks passed
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 27, 2025

Thanks everyone -- this was a long time coming!

@psvri psvri deleted the msrv branch March 28, 2025 07:37
@psvri
Copy link
Copy Markdown
Contributor Author

psvri commented Mar 28, 2025

Thanks everyone for the help in merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold left review comments

@mbrobbel mbrobbel mbrobbel left review comments

@etseidl etseidl etseidl left review comments

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt a MSRV policy

5 participants

@psvri @alamb @tustvold @mbrobbel @etseidl