[Variant] Add flag in ObjectBuilder to control validation behavior on duplicate field write#7801
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @micoo227 -- this looks really neat. I have a few comments -- let me know what you think
cc @scovich and @friendlymatthew
micoo227
force-pushed
the
dupe-field-write-flag
branch
from
d47c92c to
9e39936
Compare
|
Hi @alamb -- thanks for the feedback! I applied the changes you requested and rebased onto main. Let me know if there are any other changes you'd like me to make |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @micoo227 -- this looks great to me
@scovich and @friendlymatthew do you have some time to review this PR as well?
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Thanks @micoo227, I just had a few comments
|
Thanks for taking a look @friendlymatthew! I reworked the PR to address your requested changes |
|
@friendlymatthew are you happy with this PR now? |
|
I merged this PR up to resolve a conflict |
Thank you very much!! |
alamb
changed the title
ObjectBuilder to control validation behavior on duplicate field writeObjectBuilder to control validation behavior on duplicate field write
3 participants
Which issue does this PR close?
Closes #7777.
What changes are included in this PR?
Added method
with_validate_unique_fieldsthat modifies anObjectBuilderto throw an error infinishif duplicate fields were inserted. The error message thrown displays all of the duplicate keys that were inserted to the object.