Skip to content

Minor: fix clippy in parquet-variant after logical conflict#7803

Merged
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/fix_clippy_again
Jun 27, 2025
Merged

Minor: fix clippy in parquet-variant after logical conflict#7803
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/fix_clippy_again

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Jun 27, 2025

Which issue does this PR close?

We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.

Rationale for this change

Clippy is failing after merging #7757 due to a logical conflict and a new clippy release:

https://github.com/apache/arrow-rs/actions/runs/15924256410/job/44917809525

error: variables can be used directly in the `format!` string
   --> parquet-variant/src/variant/list.rs:130:25
    |
130 |             Err(err) => panic!("validation error: {}", err),
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
    |
1[30](https://github.com/apache/arrow-rs/actions/runs/15924256410/job/44917809525#step:6:31) -             Err(err) => panic!("validation error: {}", err),
130 +             Err(err) => panic!("validation error: {err}"),
    |

What changes are included in this PR?

Fix clippy to get CI clean on main

Are these changes tested?

By CI

Are there any user-facing changes?

No

@github-actions github-actions Bot added the parquet Changes to the parquet crate label Jun 27, 2025
@alamb alamb changed the title Minor: fix clippy after logical conflict Minor: fix clippy in parquet-variant after logical conflict Jun 27, 2025
@alamb alamb merged commit e8017f7 into apache:main Jun 27, 2025
14 checks passed
@alamb alamb deleted the alamb/fix_clippy_again branch June 27, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant