Merged
Conversation
alamb
reviewed
Jun 30, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @zeevm this seems good to me, but I worry we will potentially break it in the future if there is no specific test.
Perhaps we could add a test perhaps in this matrix:
arrow-rs/.github/workflows/parquet.yml
Line 115 in d5339f3
BTW can you share your usecase for using the rust backend
CC @psvri as you added the code to use zlib sys in
Contributor
|
Marking as draft as I think this PR is no longer waiting on feedback and I am trying to make it easier to find PRs in need of review. Please mark it as ready for review when it is ready for another look |
Contributor
Author
|
@alamb I've added the tests as requested |
alamb
approved these changes
Jul 3, 2025
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
|
THnak you @zeevm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Allow choosing the previously default "rust_backend" instead of "libz-rs-sys" for flate2 dependency.
What changes are included in this PR?
Two new features, "flate2-rust_backened" and "flate2-zlib-rs".
Are there any user-facing changes?
When enabling "flate2", one of these must also be enabled.