Make BooleanBufferBuilder get_bit not require mutable reference #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 82.54% 82.54%
=======================================
Files 168 168
Lines 47912 47917 +5
=======================================
+ Hits 39548 39554 +6
+ Misses 8364 8363 -1
Continue to review full report at Codecov.
|
nevi-me
approved these changes
Sep 18, 2021
| } | ||
|
|
||
| #[test] | ||
| fn test_bool_buffer_builder_get_first_bit_not_requires_mutability() { |
Contributor
There was a problem hiding this comment.
I think you could omit this test, because the function taking an immutable reference is enough.
Contributor
There was a problem hiding this comment.
Given that I managed to do the fuckup of requiring a mutable reference, I'd prefer to keep this test to prevent the possibility of this happening in the future (although unlikely). I hope you are OK with this.
Dandandan
approved these changes
Sep 19, 2021
Contributor
|
Thanks @boazberman |
1 similar comment
Contributor
|
Thanks @boazberman |
alamb
pushed a commit
that referenced
this pull request
Sep 21, 2021
alamb
added a commit
that referenced
this pull request
Sep 21, 2021
#792) Co-authored-by: Boaz <berman.boaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR is a followup to #693 in which I did the insanely stupid mistake of requiring a mutable reference instead of immutable reference. This PR fixes this (and adds a test to validate it...).
This is required to finish apache/datafusion#884
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?