[Variant] feat: Add optional serde_json dependency of parquet-variant#7845
Closed
Weijun-H wants to merge 2 commits intoapache:mainfrom
Closed
[Variant] feat: Add optional serde_json dependency of parquet-variant#7845Weijun-H wants to merge 2 commits intoapache:mainfrom
serde_json dependency of parquet-variant#7845Weijun-H wants to merge 2 commits intoapache:mainfrom
Conversation
Weijun-H
force-pushed
the
7775-optional-serde-json
branch
from
314ba88 to
003806e
Compare
Weijun-H
changed the title
serde_json dependencyserde_json dependency of parquet-variant
Weijun-H
changed the title
serde_json dependency of parquet-variantserde_json dependency of parquet-variant
Contributor
|
Can we potentially hold off on this PR until we get #7783 from @harshmotw-db merged? |
Contributor
|
I have an alternate proposal, let me know what you think: |
Member
Author
Nice approach, it should have a separate case. @alamb 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
serde_jsonan optional dependency ofparquet-variant#7775Rationale for this change
serde_jsonis not always needed for all use cases of parquet-variant. Making it optional reduces unnecessary dependencies and allows for more lightweight builds.What changes are included in this PR?
serde_jsonis not the dependency ofparquet-variantby defaultAre these changes tested?
Tests were added for both default and
--all-featuresconfigurations.Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.