[Variant] Follow up nits and uncomment test cases#7846
Merged
alamb merged 1 commit intoapache:mainfrom Jul 3, 2025
Merged
Conversation
scovich
approved these changes
Jul 2, 2025
Comment on lines
-400
to
-401
| // https://github.com/apache/arrow-rs/issues/7784 | ||
| // Fixme: The following assertion will panic! That is not good |
Contributor
There was a problem hiding this comment.
Does this mean the underlying bug has indeed been fixed now?
alamb
approved these changes
Jul 3, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @scovich and @friendlymatthew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR uncomments test cases that would panic or cause undesired behavior. It also follows up from comments in #7808