[Variant] Add variant_get and Shredded VariantArray#8021
Merged
alamb merged 18 commits intoapache:mainfrom Aug 7, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_getkernel for shredded variants #7941Rationale for this change
This is has a proposal for how to structure shredded
VariantArrays and thevariant_getkernelIf people like the basic idea I will file some more tickets to track additional follow on work
It is based on ideas ideas from @carpecodeum in #7946 and @scovich in #7915
I basically took the tests from #7965 and the conversation with @scovich recorded from #7941 (comment) and I bashed out how this might look
What changes are included in this PR?
VariantArrayto represent shreddingvariant_getto support extracting paths as both variants and typed fieldsNote there are many things that are NOT in this PR that I envision doing as follow on PRs:
PathsStringArray,StringViewArray, etcAre these changes tested?
Yes
Are there any user-facing changes?
New feature