[VARIANT] Add support for DataType::Utf8/LargeUtf8/Utf8View for cast_to_variant#8089
Merged
alamb merged 5 commits intoapache:mainfrom Aug 14, 2025
Merged
[VARIANT] Add support for DataType::Utf8/LargeUtf8/Utf8View for cast_to_variant#8089alamb merged 5 commits intoapache:mainfrom
alamb merged 5 commits intoapache:mainfrom
Conversation
carpecodeum
changed the title
klion26
reviewed
Aug 8, 2025
Weijun-H
previously requested changes
Aug 9, 2025
Comment on lines
487
to
1185
Member
There was a problem hiding this comment.
why not using StringArray::from?
klion26
reviewed
Aug 11, 2025
Member
There was a problem hiding this comment.
Can we reuse the macro cast_conversion here?
alamb
reviewed
Aug 11, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @carpecodeum -- I think @klion26 and @Weijun-H have some excellent comments and suggestions for this PR
github-actions
Bot
added
arrow
carpecodeum
force-pushed
the
utf8cast
branch
2 times, most recently
from
76d5cd5 to
5570608
Compare
Contributor
|
Hi @carpecodeum -- I can't merge this PR because github says it has a conflict (and since I can't push commits to your fork I can't resolve them myself) 
Could you
|
Contributor
Author
Yes, I will make those changes as well, totally missed this |
Contributor
|
Thank you @carpecodeum @klion26 and @Weijun-H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DataType::Utf8/LargeUtf8/Utf8Viewsupport forcast_to_variantkernel #8049Rationale for this change
Add support for DataType::Utf8/LargeUtf8/Utf8View for cast_to_variant
What changes are included in this PR?
Added support for casting and added tests as well
Are these changes tested?
Yes
Are there any user-facing changes?
yes casting to variant is a user facing issue
Props to @mprammer!!