[Variant] Support Timestamp to variant for cast_to_variant kernel#8113
Merged
alamb merged 5 commits intoapache:mainfrom Aug 13, 2025
Merged
[Variant] Support Timestamp to variant for cast_to_variant kernel#8113alamb merged 5 commits intoapache:mainfrom
cast_to_variant kernel#8113alamb merged 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
This is pretty DRY so feel free to propose wetting it |
abacef
commented
Aug 12, 2025
| let timestamp = DateTime::from_timestamp_nanos(microseconds * 1000); | ||
| run_test( | ||
| array_tz, | ||
| vec![Some(Variant::TimestampMicros(timestamp)), None], |
alamb
changed the title
cast_to_variant kernel
Contributor
|
I merged up to resolve a conflict |
Contributor
|
Thanks again @abacef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
DataType::Timestamp(..)support forcast_to_variantkernel #8058 .Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are these changes tested?
We typically require tests for all PRs in order to:
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
I am pretty sure I tested all the code paths
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
There is some documentation saying that nanoseconds will get truncated when converted