[Variant] [Shredding] feat: Support typed_access for Date32#8379
Merged
alamb merged 2 commits intoapache:mainfrom Sep 19, 2025
Merged
[Variant] [Shredding] feat: Support typed_access for Date32#8379alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
parquet
Contributor
|
(also 👋 welcome back!) |
Contributor
Author
|
Thank you @alamb ! Glad to be back and looking forward to contributing more! |
Contributor
I think now that @scovich and @carpecodeum have sorted out the high level strategy for shredding we'll have a bunch more work to fill out the implementation. I'll file more tickets next week |
scovich
reviewed
Sep 22, 2025
| ]); | ||
|
|
||
| let struct_array = StructArrayBuilder::new() | ||
| .with_field("metadata", Arc::new(metadata), true) |
Contributor
There was a problem hiding this comment.
metadata is non-nullable...
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Date32#8330.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
N/A