[Decimal] Add scale argument to validation functions to ensure accurate error logging #8396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
force-pushed
the
8382-decimal-display
branch
from
81f5411 to
3b3c6b0
Compare
… precision checks
Weijun-H
force-pushed
the
8382-decimal-display
branch
from
3b3c6b0 to
e87504e
Compare
Weijun-H
force-pushed
the
8382-decimal-display
branch
from
ed8cd9b to
4e6a05e
Compare
alamb
approved these changes
Sep 22, 2025
|
|
||
| /// Validates that `value` contains no more than `precision` decimal digits | ||
| fn validate_decimal_precision(value: Self::Native, precision: u8) -> Result<(), ArrowError>; | ||
| fn validate_decimal_precision( |
Contributor
There was a problem hiding this comment.
this is technically a breaking API change as it adds new functions. However, I think it is reasonable
Contributor
There was a problem hiding this comment.
Could you potentially add a new function with the new signature and deprecate the old one to ease upgrades?
Contributor
There was a problem hiding this comment.
I re-reviewed this and I think I missed it was a trait method (and we had some bad luck trying to deprecate traits) -- the compiler doesn't seem to complain if you implement a deprecated trait 🤔
Maybe we should just keep it the way you original had it? If you agree I can revert the cahnge
Member
Author
There was a problem hiding this comment.
No worry, I reverted the change
Weijun-H
force-pushed
the
8382-decimal-display
branch
from
3107320 to
307a217
Compare
Contributor
|
Thanks again @Weijun-H |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?