Merged
Conversation
friendlymatthew
commented
Nov 19, 2025
Contributor
Author
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Self review
Comment on lines
314
to
328
Contributor
Author
There was a problem hiding this comment.
Turns out we can derive the UnionMode by calling UnionArray::is_dense. But I wonder if a better API would to actually return the enum 🤔
friendlymatthew
force-pushed
the
friendlymatthew/unionarray_fields
branch
from
60a9f2c to
61db082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR adds another method on the
UnionArrayapi that returns a list ofFieldRefs associated with the union typeSee: #8838 (comment)