Skip to content

Add claim method to recordbatch for memory accounting#9433

Merged
alamb merged 1 commit intoapache:mainfrom
pydantic:claim_recordbatch
Mar 18, 2026
Merged

Add claim method to recordbatch for memory accounting#9433
alamb merged 1 commit intoapache:mainfrom
pydantic:claim_recordbatch

Conversation

@cetra3
Copy link
Copy Markdown
Contributor

@cetra3 cetra3 commented Feb 18, 2026

Which issue does this PR close?

None specifically but aligns with some of the changes in #8137

Rationale for this change

It should be easy to claim a RecordBatch in totality with an arrow memory pool

What changes are included in this PR?

Adds a few methods to bubble up the claim to RecordBatch level if the pool feature is enabled.

Are these changes tested?

Yes & new tests added

Are there any user-facing changes?

If pool feature is added, a new claim method on RecordBatch and associated structs

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Feb 18, 2026
Copy link
Copy Markdown
Contributor

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Dandandan @Jefffrey do you mind taking a look?

@cetra3 cetra3 force-pushed the claim_recordbatch branch from 54d6e15 to 6208900 Compare March 11, 2026 22:54
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

At some point we should probably add some tests / API examples to show how to use these APIs

@alamb alamb merged commit ea3c050 into apache:main Mar 18, 2026
26 checks passed
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 18, 2026

Thanks again @cetra3 and @friendlymatthew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants