Add claim method to recordbatch for memory accounting#9433
Merged
alamb merged 1 commit intoapache:mainfrom Mar 18, 2026
Merged
Conversation
friendlymatthew
approved these changes
Feb 18, 2026
Contributor
friendlymatthew
left a comment
There was a problem hiding this comment.
cc @Dandandan @Jefffrey do you mind taking a look?
54d6e15 to
6208900
Compare
alamb
approved these changes
Mar 17, 2026
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me
At some point we should probably add some tests / API examples to show how to use these APIs
Contributor
|
Thanks again @cetra3 and @friendlymatthew |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None specifically but aligns with some of the changes in #8137
Rationale for this change
It should be easy to claim a
RecordBatchin totality with an arrow memory poolWhat changes are included in this PR?
Adds a few methods to bubble up the
claimtoRecordBatchlevel if thepoolfeature is enabled.Are these changes tested?
Yes & new tests added
Are there any user-facing changes?
If
poolfeature is added, a newclaimmethod onRecordBatchand associated structs