Skip to content

[Variant] Add VariantArrayBuilder::append_nulls API #9685

Merged
scovich merged 6 commits intoapache:mainfrom
sdf-jkl:VariantArrayBuilder_append_nulls
Apr 10, 2026
Merged

[Variant] Add VariantArrayBuilder::append_nulls API #9685
scovich merged 6 commits intoapache:mainfrom
sdf-jkl:VariantArrayBuilder_append_nulls

Conversation

@sdf-jkl
Copy link
Copy Markdown
Contributor

@sdf-jkl sdf-jkl commented Apr 9, 2026

Which issue does this PR close?

Rationale for this change

Check issue

What changes are included in this PR?

  • Add VariantArrayBuilder::append_nulls
  • Add unit test
  • add fast paths for cast_to_variant_with_options and string_array_to_variant

Are these changes tested?

Yes, added a unit test

Are there any user-facing changes?

A new public API

@github-actions github-actions Bot added the parquet-variant parquet-variant* crates label Apr 9, 2026
@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Apr 9, 2026 •
edited
Loading

@scovich please take a look

klion26
klion26 reviewed Apr 10, 2026
View reviewed changes
Comment thread parquet-variant-compute/src/from_json.rs Outdated
Comment thread parquet-variant-compute/src/variant_array_builder.rs Outdated
@sdf-jkl
Copy link
Copy Markdown
Contributor Author

sdf-jkl commented Apr 10, 2026

@klion26 thanks for the review!

scovich
scovich reviewed Apr 10, 2026
View reviewed changes
Comment thread parquet-variant-compute/src/from_json.rs Outdated
Comment thread parquet-variant-compute/src/variant_array_builder.rs Outdated
scovich
scovich approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@scovich scovich merged commit 4778077 into apache:main Apr 10, 2026
17 checks passed
@sdf-jkl sdf-jkl deleted the VariantArrayBuilder_append_nulls branch April 10, 2026 19:09
@sdf-jkl sdf-jkl mentioned this pull request Apr 10, 2026
Open
@alamb alamb mentioned this pull request Apr 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scovich scovich scovich approved these changes

+1 more reviewer

@klion26 klion26 klion26 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

parquet-variant parquet-variant* crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Variant] Add VariantArrayBuilder::append_nulls API

3 participants

@sdf-jkl @klion26 @scovich