Skip to content

minor: Re-enable CDC bench #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Apr 10, 2026
Merged

minor: Re-enable CDC bench #9686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1becb14
re-enable cdc bench
etseidl Apr 9, 2026
66305d5
forgot import
etseidl Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions parquet/benches/arrow_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use arrow::util::bench_util::{create_f16_array, create_f32_array, create_f64_arr
use arrow::{record_batch::RecordBatch, util::data_gen::*};
use arrow_array::RecordBatchOptions;
use parquet::errors::Result;
use parquet::file::properties::{WriterProperties, WriterVersion};
use parquet::file::properties::{CdcOptions, WriterProperties, WriterVersion};

fn create_primitive_bench_batch(
size: usize,
Expand Down Expand Up @@ -457,12 +457,10 @@ fn create_writer_props() -> Vec<(&'static str, WriterProperties)> {
.build();
props.push(("zstd_parquet_2", prop));

// Disabled until https://github.com/apache/arrow-rs/issues/9637 is fixed
//
// let prop = WriterProperties::builder()
// .set_content_defined_chunking(Some(CdcOptions::default()))
// .build();
// props.push(("cdc", prop));
let prop = WriterProperties::builder()
.set_content_defined_chunking(Some(CdcOptions::default()))
.build();
props.push(("cdc", prop));

props
}
Expand Down
Loading