Skip to content

Conversation

@thisisnic
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

limitations under the License.
{% endcomment %}
-->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an intro paragraph

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've chucked in a sentence below but not sure if it's enough? Wasn't really sure what else to highlight

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, have added first contribs here now!

@jonkeane
Copy link
Member

jonkeane commented Nov 4, 2021

Ok, I've made a few suggestions. I'm happy to commit them myself and clean up any conflicting bits in them, but wanted to give you a chance to read through them and make sure I'm not doing anything terrible/counterproductive, @thisisnic

@thisisnic
Copy link
Member Author

Ok, I've made a few suggestions. I'm happy to commit them myself and clean up any conflicting bits in them, but wanted to give you a chance to read through them and make sure I'm not doing anything terrible/counterproductive, @thisisnic

Thanks @jonkeane , have made a few tiny changes, but otherwise looks great!

@thisisnic
Copy link
Member Author

@nealrichardson This is ready for another look!

Copy link
Contributor

@drabastomek drabastomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this content! Left some minor comments/tweaks.

nealrichardson and others added 4 commits November 6, 2021 10:51
Co-authored-by: Tomek Drabas <drabas.t@gmail.com>
Co-authored-by: Tomek Drabas <drabas.t@gmail.com>
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small edits

Co-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@nealrichardson nealrichardson merged commit 7fb4e36 into apache:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants