-
Notifications
You must be signed in to change notification settings - Fork 122
Update docs versions.json #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The R docs versions.json file was not updated during the release - this PR adds the changes which the release script should have generated.
|
Note that the other old version docs are in x.y directories (e.g. 6.0) but the last release is 7.0.0: https://github.com/apache/arrow-site/tree/asf-site/docs/7.0.0 So we need to |
|
Yes, good catch, just renamed those. So that's another thing to fix in the release script |
Do we have a JIRA yet for that? |
|
I was looking for a mistake in the PR I made for this (apache/arrow#12355), but so it's actually how you invoke the script, and that is currently not in the Arrow source code, but in the confluence wiki (we should maybe consider to move that to our development docs) |
nealrichardson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't verify the version.json changes because I think a URL is hard-coded to the arrow site, but the change looks right.
|
Confirmed that the deploy looks good |
|
It seems that we should have removed patch version from mv docs_temp docs/$(echo ${previous_version} | sed -e 's/^\([0-9]*\.[0-9]*\)\..*$/\1/') |
|
We can remove the |
The R docs versions.json file was not updated during the release - this PR adds the changes which the release script should have generated.