Skip to content

Conversation

@thisisnic
Copy link
Member

The R docs versions.json file was not updated during the release - this PR adds the changes which the release script should have generated.

thisisnic and others added 4 commits May 12, 2022 20:36
The R docs versions.json file was not updated during the release - this PR adds the changes which the release script should have generated.
@jorisvandenbossche jorisvandenbossche changed the title Update R docs versions.json Update docs versions.json May 12, 2022
@nealrichardson
Copy link
Member

Note that the other old version docs are in x.y directories (e.g. 6.0) but the last release is 7.0.0: https://github.com/apache/arrow-site/tree/asf-site/docs/7.0.0

So we need to git mv docs/7.0.0 docs/7.0 for this to not have broken links (and we probably need to fix the script that puts it there for the future).

@jorisvandenbossche
Copy link
Member

Yes, good catch, just renamed those. So that's another thing to fix in the release script

@nealrichardson
Copy link
Member

Yes, good catch, just renamed those. So that's another thing to fix in the release script

Do we have a JIRA yet for that?

@jorisvandenbossche
Copy link
Member

I was looking for a mistake in the PR I made for this (apache/arrow#12355), but so it's actually how you invoke the script, and that is currently not in the Arrow source code, but in the confluence wiki (we should maybe consider to move that to our development docs)

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't verify the version.json changes because I think a URL is hard-coded to the arrow site, but the change looks right.

@nealrichardson nealrichardson merged commit 216e98d into asf-site May 12, 2022
@nealrichardson nealrichardson deleted the update-r-docs-version branch May 12, 2022 21:02
@nealrichardson
Copy link
Member

Confirmed that the deploy looks good

@kou
Copy link
Member

kou commented May 13, 2022

It seems that we should have removed patch version from previous_version here: https://github.com/apache/arrow/pull/12355/files#diff-ae6e7dcbd5646d2ecbed30d2c82bec3c6e8bb47271280aa1795f7a3455172e7dR84

   mv docs_temp docs/$(echo ${previous_version} | sed -e 's/^\([0-9]*\.[0-9]*\)\..*$/\1/')

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented May 13, 2022

We can remove the .0 in the script, but that's the only thing it is used for, so we could also document to use the script with passing it the shorter name (although handling it in the script will probably be more robust to avoid exactly what we had here ;))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants