ARROW-11666: Add golden files for decimal256 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiszk
changed the title
Member
Author
|
@pitrou Could you please review this? It works well on my local big-endian machine. |
Member
|
Thanks. Can you also remove the "large batch" files in the endian directories? They are heavy to run and don't bring anything IMHO. |
Member
Author
|
Sure, done |
pitrou
approved these changes
Feb 25, 2021
Member
|
Now you need to update the testing submodule in the Arrow main repo :-) |
This was referenced Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds golden files for decimal256 in big and little endians.