Compilation error on Mac with -DARROW_PYTHON=on #16434
Description
It looks like compiling Arrow with -DARROW_PYTHON=on failed for a Ray user on MacOS.
The logs are attached (one failed with -DARROW_PYTHON=on and one succeeded without that flag).
The issue was originally reported at ray-project/ray#461.
I think the first couple errors are:
In file included from /Users/gmedasani/Documents/bigdata/project-ray/build_arrow_temp/arrow/cpp/src/arrow/python/common.cc:22:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/sstream:174:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/ostream:138:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/ios:216:
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/__locale:468:15: error: C++ requires a type specifier for all declarations
char_type toupper(char_type __c) const
^
/Users/gmedasani/software/anaconda_2_7/anaconda/include/python2.7/pyport.h:731:29: note: expanded from macro 'toupper'
#define toupper(c) towupper(btowc(c))
^
In file included from /Users/gmedasani/Documents/bigdata/project-ray/build_arrow_temp/arrow/cpp/src/arrow/python/common.cc:22:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/sstream:174:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/ostream:138:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/ios:216:
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/__locale:474:48: error: too many arguments provided to function-like macro invocation
const char_type* toupper(char_type* __low, const char_type* __high) const
^
/Users/gmedasani/software/anaconda_2_7/anaconda/include/python2.7/pyport.h:731:9: note: macro 'toupper' defined here
#define toupper(c) towupper(btowc(c))
^Some environment information
> python --version
Python 2.7.12 :: Anaconda custom (x86_64)
> system_profiler SPSoftwareDataType
Software:
System Software Overview:
System Version: macOS 10.12.4 (16E195)
Kernel Version: Darwin 16.5.0
Boot Volume: Macintosh HD
> conda install libgcc
Fetching package metadata .........
Solving package specifications: .
# All requested packages already installed.
libgcc 4.8.5Reporter: Robert Nishihara / @robertnishihara
Assignee: Philipp Moritz / @pcmoritz
Related issues:
- Arrow 0.3 release (blocks)
Original Issue Attachments:
Note: This issue was originally created as ARROW-826. Please see the migration documentation for further details.