[C++] Dictionary tests disabled under MinGW builds

[asfimport]

Follow up to needed for arrow/pull/3693/files.

Under cpp/src/arrow/CMakeLists.txt, PR disabled array-dict-test.cc test, by adding:

 

if(WIN32)
	 add_arrow_test(array-test
			SOURCES
			array-test.cc
			array-binary-test.cc
			array-list-test.cc
			array-struct-test.cc)
else()
	 add_arrow_test(array-test
			SOURCES
			array-test.cc
			array-binary-test.cc
			array-dict-test.cc
			array-list-test.cc
			array-struct-test.cc)
endif()

 

Which should be reverted and investigated further. The build error that including this test triggers is the following:

/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xb9a2): undefined reference to `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType> const&, arrow::MemoryPool*)'
CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xcb8a): undefined reference to `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType> const&, arrow::MemoryPool*)'
CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0xeef8): undefined reference to `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType> const&, arrow::MemoryPool*)'
CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x10240): undefined reference to `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::DictionaryBuilder(std::shared_ptr<arrow::DataType> const&, arrow::MemoryPool*)'
CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x104fc): undefined reference to `arrow::DictionaryBuilder<arrow::FixedSizeBinaryType>::AppendArray(arrow::Array const&)'
CMakeFiles/arrow-array-test.dir/objects.a(array-dict-test.cc.obj):array-dict-test.cc:(.text+0x108ef): undefined reference to `arrow

Reporter: Javier Luraschi / @javierluraschi
Assignee: Kouhei Sutou / @kou

PRs and other links:

• GitHub Pull Request #4255

_{Note: This issue was originally created as ARROW-4725. Please see the migration documentation for further details.}

[asfimport]

Antoine Pitrou / @pitrou:
Unfortunately, "if(WIN32)" will probably disable the tests also on MSVC, which it shouldn't :-(

@wesm

[asfimport]

Wes McKinney / @wesm:
Issue resolved by pull request 4255
#4255