[R] Add AWS SDK to system dependencies for macOS and Windows

[asfimport]

The Arrow C++ library now has an S3 filesystem implementation (ARROW-453), and in order to take advantage of that from R, we need to add the aws-sdk-cpp dependency to the macOS and Windows toolchains.

There is no PKGBUILD for this at https://github.com/msys2/MINGW-packages, but https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=aws-sdk-cpp-git has one.

For macOS, there already is a formula at https://github.com/Homebrew/homebrew-core/blob/master/Formula/aws-sdk-cpp.rb, maybe that's sufficient?

Once that is in place, we can enable ARROW_S3=ON in cmake and build with it (https://github.com/apache/arrow/pull/5167/files#diff-b048bf4c1679dce1028fd897a7c43b93R177)

cc @jeroen

Reporter: Neal Richardson / @nealrichardson
Assignee: Neal Richardson / @nealrichardson

Related issues:

• [R] Implement S3 file-system interface in R (is depended upon by)

PRs and other links:

• GitHub Pull Request #5579
• GitHub Pull Request #7928

_{Note: This issue was originally created as ARROW-6437. Please see the migration documentation for further details.}

[asfimport]

Neal Richardson / @nealrichardson:
I've started trying to build this on Windows on the rtools-packages project: https://github.com/nealrichardson/rtools-packages/blob/master/mingw-w64-aws-sdk-cpp/PKGBUILD

It's failing and I'm struggling to see the root cause: https://ci.appveyor.com/project/nealrichardson/rtools-packages/build/job/6c4biugb7f0ioele

@pitrou any ideas?

[asfimport]

Antoine Pitrou / @pitrou:
Several things here:

• It strikes me that the CMake logs say it's using cl.exe as a compiler. Shouldn't it be using MinGW's gcc instead?

• It's likely that CMake is using Visual Studio as a generator, not Makefiles, which would explain the "make: *** No targets specified and no makefile found. Stop." This page might help: https://github.com/tudelft3d/masbcpp/wiki/Building-on-Windows-with-CMake-and-MinGW

• CMake is probably pre-installed on AppVeyor, so perhaps that version is being used rather than the MinGW-installed one?

  Also, for the record, here are the build scripts we're using on conda-forge:
  https://github.com/conda-forge/aws-sdk-cpp-feedstock/blob/master/recipe/build.sh
  https://github.com/conda-forge/aws-sdk-cpp-feedstock/blob/master/recipe/bld.bat

[asfimport]

Neal Richardson / @nealrichardson:
Following up: appears that aws-sdk-cpp doesn't work on mingw. See r-windows/rtools-packages#37

So S3 support will have to be flagged based on whether the C++ library is built with ARROW_S3=ON, and that won't be on for Windows.

I'll try to update the homebrew/autobrew formula though so we can have macOS support.

[asfimport]

Francois Saint-Jacques / @fsaintjacques:
Issue resolved by pull request 5579
#5579

[asfimport]

Neal Richardson / @nealrichardson:
autobrew needs to address the static linking issue, and homebrew-cpp was reverted in ARROW-7105

[asfimport]

Neal Richardson / @nealrichardson:
PR to add (update) aws-sdk-cpp to the autobrew project: autobrew/homebrew-core#2

[asfimport]

Neal Richardson / @nealrichardson:
This is a bigger challenge and isn't going to go in the next release, unfortunately.

[asfimport]

Neal Richardson / @nealrichardson:
Issue resolved by pull request 7928
#7928