Skip to content

[Java] Enhance TransferPair related parameters check and tests #23199

@asfimport

Description

@asfimport

TransferPair related param checks in different classes have potential problems:

i. copyValueSafe do not check from index, if from > valueCount, no error is shown.

ii. splitAndTansfer has no indices check in classes like VarcharVector

iii. splitAndTranser indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately.

iv. some assert usages should be replaced with Preconditions.

v. should add more UT to cover corner cases.

Reporter: Ji Liu / @tianchen92
Assignee: Ji Liu / @tianchen92

PRs and other links:

Note: This issue was originally created as ARROW-6871. Please see the migration documentation for further details.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions